[PATCH v2 1/2] reftable/record: fix memory leak when decoding object records
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Mar 7, 2024, 20:35 UTC
- Message-ID
- <a963054f9a063ca0c4fdcf613fd0ab2e9c681ac9.1709843663.git.ps@pks.im>
- In-Reply-To
- <cover.1709843663.git.ps@pks.im>
When decoding records it is customary to reuse a `struct reftable_ref_record` across calls. Thus, it may happen that the record already holds some allocated memory. When decoding ref and log records we handle this by releasing or reallocating held memory. But we fail to do this for object records, which causes us to leak memory.
Fix this memory leak by releasing object records before we decode into them. We may eventually want to reuse memory instead to avoid needless reallocations. But for now, let's just plug the leak and be done.
Signed-off-by: Patrick Steinhardt <ps@pks.im> --- reftable/record.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/reftable/record.c b/reftable/record.c index d6bb42e887..9c31feb35c 100644 --- a/reftable/record.c +++ b/reftable/record.c @@ -569,6 +569,8 @@ static int reftable_obj_record_decode(void *rec, struct strbuf key, uint64_t last; int j; + reftable_obj_record_release(r); + REFTABLE_ALLOC_ARRAY(r->hash_prefix, key.len); memcpy(r->hash_prefix, key.buf, key.len); r->hash_prefix_len = key.len;
-- 2.43.1