Re: [PATCH] revision: fix missing null for freed memory

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 11, 2025, 23:09 UTC
Message-ID: <xmqqmsesw01l.fsf@gitster.g>
In-Reply-To: <20250211212909.GA3113114@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

> Doing that shows that v2.37.0 is actually bad. And bisecting shows that
> it has been broken since 087c745833 (log: add a --no-graph option,
> 2022-02-11), which is not too surprising.

Yeah, broken from its beginning is usually how these kinds of bugs turn out to be.

Show 8 quoted lines

> I've also run into non-determinism when bisecting like this, because my
> test command depends on the value of HEAD. The best solution here is to
> just feed a stable tip to git-log. I bisected on:
>
>   git log --graph --no-graph --patch origin >/dev/null
>
> (I didn't need "-2" because good commits failed with "unrecognized
> argument" and bad ones were killed by ASan immediately ;) ).

Thanks for sharing a good tip.