git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] revision: fix missing null for freed memory

From
Patrick Steinhardt <ps@pks.im>
Date
Feb 11, 2025, 07:55 UTC
Message-ID
<Z6sCeYmljrqWRFnS@pks.im>
In-Reply-To
<20250208061702.88469-1-forivall@gmail.com>
On Fri, Feb 07, 2025 at 10:17:02PM -0800, Emily M Klassen wrote:
Show 9 quoted lines
> "git log --graph --no-graph" missed cleaning up the output_prefix and
> output_prefix_data pointers. This resulted in a segfault when using "--patch",
> "--name-status" or "--name-only", as the output_prefix_data continued to be in
> use after free()
> 
> Signed-off-by: Emily M Klassen <forivall@gmail.com>
> ---
> I previously reported this a few hours ago, and ended up digging in and figuring
> it out. I'll make sure to bottom reply in the follow ups to this patch.

Do we know when this bug was introduced? Is it a recent regression or a long-standing issue? Might be nice to point out in the commit message if we do know.

Patrick
Previous: Junio C HamanoNext: D. Ben Knoble
Message 6 of 12 in “revision: fix missing null for freed memory”
  1. revision: fix missing null for freed memoryEmily M Klassen, Feb 8, 2025
  2. Junio C HamanoFeb 8, 2025
  3. Junio C HamanoFeb 10, 2025
  4. Emily KlassenFeb 10, 2025
  5. Junio C HamanoFeb 13, 2025
  6. Patrick SteinhardtFeb 11, 2025
  7. D. Ben KnobleFeb 11, 2025
  8. D. Ben KnobleFeb 11, 2025
  9. Jeff KingFeb 11, 2025
  10. Junio C HamanoFeb 11, 2025
  11. Patrick SteinhardtFeb 12, 2025
  12. Ben KnobleFeb 13, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.