Re: [PATCH] revision: fix missing null for freed memory
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Feb 11, 2025, 07:55 UTC
- Message-ID
- <Z6sCeYmljrqWRFnS@pks.im>
- In-Reply-To
- <20250208061702.88469-1-forivall@gmail.com>
On Fri, Feb 07, 2025 at 10:17:02PM -0800, Emily M Klassen wrote:
Show 9 quoted lines
> "git log --graph --no-graph" missed cleaning up the output_prefix and > output_prefix_data pointers. This resulted in a segfault when using "--patch", > "--name-status" or "--name-only", as the output_prefix_data continued to be in > use after free() > > Signed-off-by: Emily M Klassen <forivall@gmail.com> > --- > I previously reported this a few hours ago, and ended up digging in and figuring > it out. I'll make sure to bottom reply in the follow ups to this patch.
Do we know when this bug was introduced? Is it a recent regression or a long-standing issue? Might be nice to point out in the commit message if we do know.
Patrick