Re: [PATCH] revision: fix missing null for freed memory

From: D. Ben Knoble <ben.knoble@gmail.com>
Date: Feb 11, 2025, 19:31 UTC
Message-ID: <CALnO6CDHZerHKaWwGc-9CmwEMiFVY+Ds5-GNWYKUi1yO7=U_Rg@mail.gmail.com>
In-Reply-To: <Z6sCeYmljrqWRFnS@pks.im>

On Tue, Feb 11, 2025 at 2:56 AM Patrick Steinhardt <ps@pks.im> wrote:

Show 17 quoted lines

>
> On Fri, Feb 07, 2025 at 10:17:02PM -0800, Emily M Klassen wrote:
> > "git log --graph --no-graph" missed cleaning up the output_prefix and
> > output_prefix_data pointers. This resulted in a segfault when using "--patch",
> > "--name-status" or "--name-only", as the output_prefix_data continued to be in
> > use after free()
> >
> > Signed-off-by: Emily M Klassen <forivall@gmail.com>
> > ---
> > I previously reported this a few hours ago, and ended up digging in and figuring
> > it out. I'll make sure to bottom reply in the follow ups to this patch.
>
> Do we know when this bug was introduced? Is it a recent regression or a
> long-standing issue? Might be nice to point out in the commit message if
> we do know.
>
> Patrick

Out of morbid curiosity, I've started bisecting this, but it's proven slightly more subtle than I anticipated. If nobody beats me to it, I'll post my results when I have them.

-- 
D. Ben Knoble