Re: [PATCH v3 0/8] enhance "string_list" code and test

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 7, 2025, 15:10 UTC
Message-ID: <xmqqms9g5967.fsf@gitster.g>
In-Reply-To: <aGdllONkAbTJt-Ud@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

Show 18 quoted lines

> On Sun, Jun 29, 2025 at 12:26:15PM +0800, shejialuo wrote:
>> Changes since v2:
>> 
>> 1. [PATCH v3 1/8]: improve the commit message to explain that we would
>>    handle a warning in the later commits.
>> 2. [PATCH v3 2/8] and [PATCH v2 3/8]: improve the commit message to add
>>    the history background.
>> 3. [PATCH v3 4/8]: improve the commit message to show why the current
>>    bianry search algorithm introduces the sign warning and how to change
>>    it to fix the sign warning.
>> 4. [PATCH v3 5/8] - [PATCH v3 8/8]: remove list into test helper instead
>>    of test itself for reducing the shared state.
>> 5. [PATCH v3 8/8]: improve the commit message to say why we can't delete
>>    "test-tool string_list" totally.
>
> Thanks, this version looks good to me!
>
> Patrick

Thanks. Will queue.