git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] ci(*-leaks): skip the git-svn tests to save time

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 16, 2026, 19:20 UTC
Message-ID
<xmqqms2d74b7.fsf@gitster.g>
In-Reply-To
<pull.2031.git.1768584676520.gitgitgadget@gmail.com>

"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 7 quoted lines
> However, testing git-svn in the leak-checking jobs provides minimal
> value: git-svn is implemented as a Perl script, and leak checking only
> handles C code. While git-svn does call into Git's built-in commands
> that are implemented in C, these are standard Git operations that are
> already thoroughly exercised elsewhere in the test suite. Therefore,
> running the git-svn tests in the leak-checking jobs only adds to the
> overall run time with little value in return.
Very nicely reasoned.  And the implementation of this idea is ...
Show 10 quoted lines
> diff --git a/ci/lib.sh b/ci/lib.sh
> index f561884d40..a165c7f268 100755
> --- a/ci/lib.sh
> +++ b/ci/lib.sh
> @@ -356,6 +356,7 @@ linux-musl-meson)
>  	;;
>  linux-leaks|linux-reftable-leaks)
>  	export SANITIZE=leak
> +	export NO_SVN_TESTS=LetsSaveSomeTime
>  	;;
... surprisingly simple.  I very much like it.
Thanks.  Will queue.
Previous: Johannes Schindelin via GitGitGadgetNext: Phillip Wood
Message 2 of 13 in “ci(*-leaks): skip the git-svn tests to save time”
  1. ci(*-leaks): skip the git-svn tests to save timeJohannes Schindelin via GitGitGadget, Jan 16, 2026
  2. Junio C HamanoJan 16, 2026
  3. Phillip WoodJan 17, 2026
  4. Junio C HamanoJan 17, 2026
  5. Kristoffer HaugsbakkJan 17, 2026
  6. Junio C HamanoJan 18, 2026
  7. Phillip WoodJan 20, 2026
  8. Phillip WoodJan 20, 2026
  9. Junio C HamanoJan 20, 2026
  10. Phillip WoodJan 23, 2026
  11. Junio C HamanoJan 23, 2026
  12. Phillip WoodJan 26, 2026
  13. Junio C HamanoJan 26, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.