Re: [PATCH] ci(*-leaks): skip the git-svn tests to save time

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 26, 2026, 16:06 UTC
Message-ID: <xmqqikcojr4k.fsf@gitster.g>
In-Reply-To: <82b656a5-e5c8-4056-8ec5-4bdab9ef7128@gmail.com>

Phillip Wood <phillip.wood123@gmail.com> writes:

Show 5 quoted lines

> I think that unless the libsvn that linked against was built with 
> -fsanitize=leak we wouldn't find any leaks in it anyway. When I wrote my 
> original mail I was imagining C implementation that forked "svn" but 
> replaced the perl code with C that called the appropriate functions in 
> libgit rather than forking git.

It was the scenario I was assuming as well, but I simply forgot to consider that we want to catch leaks in our "client" code (client from the point of view of the libsvn library).

And you are right. It can be done to check our leaks without being able to touch libsvn to fix their leaks, even though we may have to filter out noises from the leak checker if there are their leaks we cannot plug.

> In that case I think there's an argument 
> for checking that our code does not leak. Anyway this is all rather 
> hypothetical as we're not likely to rewrite these scripts in C.

;-).