git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] ci(*-leaks): skip the git-svn tests to save time

From
Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>
Date
Jan 16, 2026, 17:31 UTC
Message-ID
<pull.2031.git.1768584676520.gitgitgadget@gmail.com>
From: Johannes Schindelin <johannes.schindelin@gmx.de>

I noticed recently that the leak-checking jobs still take a lot of time, and upon analysis, the git-svn tests contribute significantly to this.

Analyzing a recent CI run, I saw that the Git test suite contains 1,017 tests, running for approximately 5¼ hours total. Of these, 65 git-svn-related tests (~6% of test count) took 42.24 minutes combined, accounting for ~13.% of the total runtime. This implies that the git-svn tests are roughly twice as expernsive compared to the other tests.

However, testing git-svn in the leak-checking jobs provides minimal value: git-svn is implemented as a Perl script, and leak checking only handles C code. While git-svn does call into Git's built-in commands that are implemented in C, these are standard Git operations that are already thoroughly exercised elsewhere in the test suite. Therefore, running the git-svn tests in the leak-checking jobs only adds to the overall run time with little value in return.

Given that the leak-checking jobs are particularly time-intensive and these 42+ minutes of SVN tests per job provide no additional leak detection value, skip them in the *-leaks jobs to reduce CI runtime.

Assisted-by: Claude Sonnet 4.5
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
    ci(*-leaks): skip the git-svn tests to save time
    
    I leaned heavily on AI to implement this patch, in particular when
    analyzing the logs. That's why I added that trailer talking about Claude
    Sonnet. If this is undesirable, please let me know.
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-2031%2Fdscho%2Fskip-svn-and-leak-tests-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-2031/dscho/skip-svn-and-leak-tests-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/2031
 ci/lib.sh | 1 +
 1 file changed, 1 insertion(+)
diff --git a/ci/lib.sh b/ci/lib.sh
index f561884d40..a165c7f268 100755
--- a/ci/lib.sh
+++ b/ci/lib.sh
@@ -356,6 +356,7 @@ linux-musl-meson)
 	;;
 linux-leaks|linux-reftable-leaks)
 	export SANITIZE=leak
+	export NO_SVN_TESTS=LetsSaveSomeTime
 	;;
 linux-asan-ubsan)
 	export SANITIZE=address,undefined

base-commit: 7264e61d87e58b9d0f5e6424c47c11e9657dfb75
-- 
gitgitgadget
Next: Junio C Hamano
Message 1 of 13 in “ci(*-leaks): skip the git-svn tests to save time”
  1. ci(*-leaks): skip the git-svn tests to save timeJohannes Schindelin via GitGitGadget, Jan 16, 2026
  2. Junio C HamanoJan 16, 2026
  3. Phillip WoodJan 17, 2026
  4. Junio C HamanoJan 17, 2026
  5. Kristoffer HaugsbakkJan 17, 2026
  6. Junio C HamanoJan 18, 2026
  7. Phillip WoodJan 20, 2026
  8. Phillip WoodJan 20, 2026
  9. Junio C HamanoJan 20, 2026
  10. Phillip WoodJan 23, 2026
  11. Junio C HamanoJan 23, 2026
  12. Phillip WoodJan 26, 2026
  13. Junio C HamanoJan 26, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.