Re: [PATCH v3] http: add http.sslVerifyStatus to check stapled OCSP responses
Junio C Hamano <gitster@pobox.com> writes:
Show 32 quoted lines
> graysongordon-gl <graysongordon1@gmail.com> writes:
>
>> v3: rename the test from t5567 to t5568. t5567 is taken on 'seen' by
>> mm/lib-httpd-cgi-safe. t5568 is free on master, next, seen, jch and
>> maint as of b9720e4723, and sits next to the other http tests. No
>> other change.
>
> I thought I first asked whether we need a new script before
> suggesting moving it out of the way because 't5567' was already
> taken. It is much better not to waste a scarce, shared resource
> such as a test number, and doing so avoids breaking the build if we
> are not careful.
>
> If we really need to add a new script, you would need to squash in
> at least a patch like this to avoid breaking Meson-based builds.
>
>
> t/meson.build | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git i/t/meson.build w/t/meson.build
> index 3219264fe7..3d68f67680 100644
> --- i/t/meson.build
> +++ w/t/meson.build
> @@ -707,6 +707,7 @@ integration_tests = [
> 't5564-http-proxy.sh',
> 't5565-push-multiple.sh',
> 't5566-push-group.sh',
> + 't5568-http-verify-status.sh',
> 't5570-git-daemon.sh',
> 't5571-pre-push-hook.sh',
> 't5572-pull-submodule.sh',
BTW, exit status of ls-remote is lost without the following:
diff --git a/t/t5568-http-verify-status.sh b/t/t5568-http-verify-status.sh
index c9167a05c2..7ba70fc8af 100755
--- a/t/t5568-http-verify-status.sh
+++ b/t/t5568-http-verify-status.sh
@@ -38,7 +38,7 @@ test_expect_success 'create http-accessible bare repository' '
# server makes the tests below fail loudly instead of silently vanishing.
test_lazy_prereq SSL_VERIFYSTATUS '
git -c http.sslVerifyStatus=true \
- ls-remote "$HTTPD_URL/smart/repo.git" 2>err
+ ls-remote "$HTTPD_URL/smart/repo.git" 2>err &&
! grep "cannot verify certificate status" err
'
Junio C Hamano <gitster@pobox.com>