Re: [PATCH v6] http: add http.sslVerifyStatus to check stapled OCSP responses

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 28, 2026, 17:20 UTC
Message-ID: <xmqqld9q40ww.fsf@gitster.g>
In-Reply-To: <CALgUfNjd_y-e-zTKJ31o8_bQuRw8wFWe=sdsf2KJ7LOmmO21aQ@mail.gmail.com>

Grayson Gordon <graysongordon1@gmail.com> writes:

Show 6 quoted lines

> Junio,
>
> Yes, I was hoping for clarity on how thorough we wanted the testing to
> be. Patrick added a lot of great stuff that I’m happy to use if that’s
> your preference, but we also talked about wanting to keep the tests
> succinct. Please let me know what you feel is most appropriate.

If you can keep them succinct but still test the essential bits, that would be great, but I am not sure if that is a great question to ask me ;-) Patrick? You said "not 100% sure given the complexity", but which parts make you feel iffy? They do look involved but seem to cover the situations we do care about, except we seem not to test when the server does not explicitly say "this is still good", or am I not reading the tests correctly?

Thanks.