Re: [PATCH v2 21/21] bisect: get back halfway shortcut
Stephan Beyer <s-beyer@gmx.net> writes:
Show 9 quoted lines
> The documentation says that when the maximum possible distance
> is found, the algorithm stops immediately. That feature is
> reestablished by this commit.
>
> Signed-off-by: Stephan Beyer <s-beyer@gmx.net>
> ---
>
> Notes:
> I plugged a memory leak here.
... relative to patch series v1, I presume?
Show 5 quoted lines
> @@ -391,7 +391,13 @@ static void traversal_up_to_merges(struct commit_list *queue,
> }
>
> update_best_bisection(top);
> + if (distance_direction(top) == 0) { // halfwaySay /* halfway */ without // double-slash comment.
The remainder of the patch makes sense to me.
Junio C Hamano <gitster@pobox.com>