Re: [PATCH v2 08/21] bisect: make bisect compile if DEBUG_BISECT is set
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Apr 15, 2016, 21:22 UTC
- Message-ID
- <xmqqd1pqa7pe.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <1460294354-7031-9-git-send-email-s-beyer@gmx.net>
Stephan Beyer <s-beyer@gmx.net> writes:
Show 6 quoted lines
> Setting the macro DEBUG_BISECT to 1 enables debugging information > for the bisect algorithm. The code did not compile due to struct > changes. > > Signed-off-by: Stephan Beyer <s-beyer@gmx.net> > ---
Thanks.
This is something that we should do as a preparatory clean-up patch before the series. The real body of the series is more important thing for us to spend review cycles on, and striving to slim it down by having preparatory bits graduate early would help the process.
Show 29 quoted lines
> bisect.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/bisect.c b/bisect.c > index 901e4d3..2f54d96 100644 > --- a/bisect.c > +++ b/bisect.c > @@ -131,7 +131,7 @@ static void show_list(const char *debug, int counted, int nr, > unsigned flags = commit->object.flags; > enum object_type type; > unsigned long size; > - char *buf = read_sha1_file(commit->object.sha1, &type, &size); > + char *buf = read_sha1_file(commit->object.oid.hash, &type, &size); > const char *subject_start; > int subject_len; > > @@ -143,10 +143,10 @@ static void show_list(const char *debug, int counted, int nr, > fprintf(stderr, "%3d", weight(p)); > else > fprintf(stderr, "---"); > - fprintf(stderr, " %.*s", 8, sha1_to_hex(commit->object.sha1)); > + fprintf(stderr, " %.*s", 8, sha1_to_hex(commit->object.oid.hash)); > for (pp = commit->parents; pp; pp = pp->next) > fprintf(stderr, " %.*s", 8, > - sha1_to_hex(pp->item->object.sha1)); > + sha1_to_hex(pp->item->object.oid.hash)); > > subject_len = find_commit_subject(buf, &subject_start); > if (subject_len)