From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 15 Apr 2016 22:53:19 GMT
Subject: Re: [PATCH v2 21/21] bisect: get back halfway shortcut
Message-ID: <xmqqlh4e7acg.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <1460294692-7402-2-git-send-email-s-beyer@gmx.net>

Stephan Beyer <s-beyer@gmx.net> writes:

> The documentation says that when the maximum possible distance
> is found, the algorithm stops immediately. That feature is
> reestablished by this commit.
>
> Signed-off-by: Stephan Beyer <s-beyer@gmx.net>
> ---
>
> Notes:
>     I plugged a memory leak here.

... relative to patch series v1, I presume?

> @@ -391,7 +391,13 @@ static void traversal_up_to_merges(struct commit_list *queue,
>  		}
>  
>  		update_best_bisection(top);
> +		if (distance_direction(top) == 0) { // halfway

Say /* halfway */ without // double-slash comment.

The remainder of the patch makes sense to me.