Re: Fixing the warning about warning(""); was: Re: [PATCH] difftool.c: mark a file-local symbol with static

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 26, 2017, 18:26 UTC
Message-ID: <xmqqlgtx65l0.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20170126143252.ne533mcv3n2ksbai@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 15 quoted lines

> On Thu, Jan 26, 2017 at 07:39:55AM +0100, Johannes Sixt wrote:
>
>> Am 25.01.2017 um 23:01 schrieb Jeff King:
>> > +#pragma GCC diagnostic ignored "-Wformat-zero-length"
>> 
>> Last time I used #pragma GCC in a cross-platform project, it triggered an
>> "unknown pragma" warning for MSVC. (It was the C++ compiler, I don't know if
>> the C compiler would also warn.) It would have to be spelled like this:
>> 
>> #pragma warning(disable: 4068)   /* MSVC: unknown pragma */
>> #pragma GCC diagnostic ignored "-Wformat-zero-length"
>> 
>> Dscho mentioned that he's compiling with MSVC. It would do him a favor.
>
> Bleh. The point of #pragma is to ignore ones you don't know about.

Yes. Let's not go there; somebody else's compiler will complain about "#pragma warning(disable: 4068)" that it does not understand.

> Anyway. I do not want to make life harder for anyone. I think there are
> several options floating around now, so I will let Junio decide which
> one he wants to pick up.

Well, I'll keep the "do nothing other than squelching this instance" to solve one of the two problems for now.

The other "can we make it harder to make the same issue and reduce the need to discuss this again on the list?" can be an independent follow-up patch, and I do have a preference (the "less horrible version, that is static inline warning_blank_line(void)" you gave us in <20170124230500.h3fasbvutjkkke5h@sigill.intra.peff.net>), but I do not think we are in a hurry.

Thanks.