Re: [PATCH] difftool.c: mark a file-local symbol with static

From: Ramsay Jones <ramsay@ramsayjones.plus.com>
Date: Dec 1, 2016, 01:18 UTC
Message-ID: <59da5383-16a0-b327-75a8-b4c4ad7bd479@ramsayjones.plus.com>
In-Reply-To: <xmqqinr4bkf4.fsf@gitster.mtv.corp.google.com>

On 30/11/16 23:46, Junio C Hamano wrote:

Show 13 quoted lines

> Jeff King <peff@peff.net> writes:
> 
>> I forgot, we ended up reversing course later and silencing them:
>>
>>   http://public-inbox.org/git/20140505052117.GC6569@sigill.intra.peff.net/
>>
>> By the rationale of that conversation, we should be doing:
>>
>>   warning("%s", "");
>>
>> here.
> 
> I forgot too.  Thanks for digging up that thread.

Yes, I blamed wt-status.c:227 and came up with commit 7d7d68022 as well.

So, by the same rationale, we should remove -Wno-format-zero-length from DEVELOPER_CFLAGS. yes?

ATB, Ramsay Jones