Re: Fixing the warning about warning(""); was: Re: [PATCH] difftool.c: mark a file-local symbol with static

From: Jeff King <peff@peff.net>
Date: Jan 26, 2017, 14:32 UTC
Message-ID: <20170126143252.ne533mcv3n2ksbai@sigill.intra.peff.net>
In-Reply-To: <546179e0-1d6e-86f7-00cf-e13218b76de1@kdbg.org>

On Thu, Jan 26, 2017 at 07:39:55AM +0100, Johannes Sixt wrote:

Show 11 quoted lines

> Am 25.01.2017 um 23:01 schrieb Jeff King:
> > +#pragma GCC diagnostic ignored "-Wformat-zero-length"
> 
> Last time I used #pragma GCC in a cross-platform project, it triggered an
> "unknown pragma" warning for MSVC. (It was the C++ compiler, I don't know if
> the C compiler would also warn.) It would have to be spelled like this:
> 
> #pragma warning(disable: 4068)   /* MSVC: unknown pragma */
> #pragma GCC diagnostic ignored "-Wformat-zero-length"
> 
> Dscho mentioned that he's compiling with MSVC. It would do him a favor.

Bleh. The point of #pragma is to ignore ones you don't know about.

It would be easy to wrap it in an #ifdef for __GNUC__ (there is already a similar pragma with similar wrapping in the code base).

Anyway. I do not want to make life harder for anyone. I think there are several options floating around now, so I will let Junio decide which one he wants to pick up.

-Peff