Re: [PATCH 4/6] fsmonitor: Add a trailing newline to test-dump-fsmonitor

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 19, 2017, 20:28 UTC
Message-ID: <xmqqlghyv4wz.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <dab89f071d22a21b85dff5d31e9e9a8ceb6458e3.1513642743.git.alexmv@dropbox.com>

Alex Vandiver <alexmv@dropbox.com> writes:

> Subject: Re: [PATCH 4/6] fsmonitor: Add a trailing newline to test-dump-fsmonitor

"Subject: fsmonitor: complete the last line of test-dump-fsmonitor output"

perhaps.

Show 17 quoted lines

> This makes it more readable when used for debugging from the
> commandline.
>
> Signed-off-by: Alex Vandiver <alexmv@dropbox.com>
> ---
>  t/helper/test-dump-fsmonitor.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/t/helper/test-dump-fsmonitor.c b/t/helper/test-dump-fsmonitor.c
> index 53b19b39b..4e56929f7 100644
> --- a/t/helper/test-dump-fsmonitor.c
> +++ b/t/helper/test-dump-fsmonitor.c
> @@ -19,5 +19,6 @@ int cmd_main(int ac, const char **av)
>  	for (i = 0; i < istate->cache_nr; i++)
>  		printf((istate->cache[i]->ce_flags & CE_FSMONITOR_VALID) ? "+" : "-");
>  
> +	printf("\n");

That (and existing) uses of printf() all feel a bit overkill ;-) Perhaps putchar() would suffice.

I am not sure if the above wants to become something like

	for (i = 0; i < istate->cache_nr; i++) {
        	putchar(istate->cache[i]->ce_flags & CE_FSMONITOR_VALID ? '+' : '-');
		quote_c_style(istate->cache[i]->name, NULL, stdout, 0);
		putchar('\n');
	}

instead of "a single long incomplete line" in the first place. Your "fix" merely turns it into "a single long complete line", which does not quite feel big enough an improvement, at least to me.

>  	return 0;
>  }