Re: [PATCH 4/6] fsmonitor: Add a trailing newline to test-dump-fsmonitor
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Dec 21, 2017, 21:49 UTC
- Message-ID
- <xmqqbmiru4xn.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <alpine.DEB.2.10.1712201744270.15915@alexmv-linux>
Alex Vandiver <alexmv@dropbox.com> writes:
Show 11 quoted lines
> The only current uses of this tool are in tests, which only examine
> the first ("no fsmonitor" / "fsmonitor last update ...") line. I find
> it useful as a brief summary view of the fsmonitor bits, but I suppose
> I'd also be happy with just presence/absence and a count of set/unset
> bits.
>
> Barring objections from Dscho or Ben, I'll reroll with a version that
> shows something like:
>
> fsmonitor last update 1513821151547101894 (5 seconds ago)
> 5 files valid / 10 files invalidAs I agree that this is test/debug only, I do not care too deeply either way, as long as it does not end with an incomplete line ;-)