git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/6] fsmonitor: Add dir.h include, for untracked_cache_invalidate_path

From
AVAlex Vandiver <alexmv@dropbox.com>
Date
Dec 20, 2017, 20:59 UTC
Message-ID
<alpine.DEB.2.10.1712201108190.10810@alexmv-linux>
In-Reply-To
<xmqqtvwmv5fl.fsf@gitster.mtv.corp.google.com>
On Tue, 19 Dec 2017, Junio C Hamano wrote:
Show 7 quoted lines
> Alex Vandiver <alexmv@dropbox.com> writes:
> 
> > Subject: Re: [PATCH 2/6] fsmonitor: Add dir.h include, for untracked_cache_invalidate_path
> 
> Perhaps
> 
> "Subject: fsmonitor.h: include dir.h"
Certainly more concise.
> But I am not sure if this is a right direction to go in.  If a .C
> user of fsmonitor needs (does not need) things from dir.h, that file
> can (does not need to) include dir.h itself.

Hm; I was patterning based on existing .h files, which don't seem shy about pulling in other .h files.

> I think this header does excessive "static inline" as premature
> optimization, so a better "fix" to your perceived problem may be to
> make them not "static inline".

Yeah, quite possibly. Ben, do you recall your rationale for inlining them in 6a6da08f6 ("fsmonitor: teach git to optionally utilize a file system monitor to speed up detecting new or changed files.", 2017-09-22) ?

 - Alex
Previous: Junio C HamanoNext: Junio C Hamano
Message 5 of 16 in “Minor fsmonitor bugfixes, use with `git diff`”
  1. 0/6 Minor fsmonitor bugfixes, use with `git diff`Alex Vandiver, Dec 19, 2017
  2. 1/6 Fix comments to agree with argument nameAlex Vandiver, Dec 19, 2017
  3. 2/6 fsmonitor: Add dir.h include, for untracked_cache_invalidate_pathAlex Vandiver, Dec 19, 2017
  4. Junio C HamanoDec 19, 2017
  5. Alex VandiverDec 20, 2017
  6. Junio C HamanoDec 21, 2017
  7. 4/6 fsmonitor: Add a trailing newline to test-dump-fsmonitorAlex Vandiver, Dec 19, 2017
  8. Junio C HamanoDec 19, 2017
  9. Alex VandiverDec 21, 2017
  10. Junio C HamanoDec 21, 2017
  11. 3/6 fsmonitor: Update helper tool, now that flags are filled laterAlex Vandiver, Dec 19, 2017
  12. Alex VandiverDec 20, 2017
  13. 6/6 fsmonitor: Use fsmonitor data in `git diff`Alex Vandiver, Dec 19, 2017
  14. 5/6 fsmonitor: Remove debugging lines from t/t7519-status-fsmonitor.shAlex Vandiver, Dec 19, 2017
  15. Junio C HamanoDec 19, 2017
  16. Johannes SchindelinDec 20, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.