Re: t7005-editor.sh failure

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 26, 2018, 18:16 UTC
Message-ID: <xmqqlg7oktto.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180926121107.GH27036@localhost>

SZEDER Gábor <szeder.dev@gmail.com> writes:

Show 5 quoted lines

> Having said all that, I didn't omit the quotes in 4362da078e with the
> above in mind; in fact I tend to use quotes even when they are
> unnecessary (e.g. in variable assignments: var="$1"), because unquoted
> variables and command substitutions freak me out before I can think
> through whether its safe to omit the quotes or not :)

I quote >"$file" (but not var=$var) because the CodingGuidelines tells me to:

 - Redirection operators should be written with space before, but no
   space after them.  In other words, write 'echo test >"$file"'
   instead of 'echo test> $file' or 'echo test > $file'.  Note that
   even though it is not required by POSIX to double-quote the
   redirection target in a variable (as shown above), our code does so
   because some versions of bash issue a warning without the quotes.

;-)

> Sidenote: this test should use the write_script helper to create this
> editor script.

Good suggestion.