t7005-editor.sh failure

From: Alexander Pyhalov <apyhalov@gmail.com>
Date: Sep 26, 2018, 06:52 UTC
Message-ID: <CALOYryFX4PPR+=1L+sjEqPsdmNh_+vNxGf0wwuAgoYzau=GShw@mail.gmail.com>

On updating git to 2.19 we've suddenly got t7005-editor.sh test failures. The issue seems to be that generated "e space.sh" file can't handle files with spaces. Instead of 'echo space >$1' it should be 'echo space > "$1"' or git editor fails when gets file with spaces in name.

The patch is simple:

-- 
Best regards,
Alexander Pyhalov,
system administrator of Southern Federal University IT department


--- git-2.19.0/t/t7005-editor.sh.~1~	Mon Sep 10 21:39:13 2018
+++ git-2.19.0/t/t7005-editor.sh	Wed Sep 26 09:41:30 2018
@@ -112,7 +112,7 @@
 done
 
 test_expect_success 'editor with a space' '
-	echo "echo space >\$1" >"e space.sh" &&
+	echo "echo space > \"\$1\"" > "e space.sh" &&
 	chmod a+x "e space.sh" &&
 	GIT_EDITOR="./e\ space.sh" git commit --amend &&
 	test space = "$(git show -s --pretty=format:%s)"