Re: t7005-editor.sh failure

From: Martin Ågren <martin.agren@gmail.com>
Date: Sep 26, 2018, 09:52 UTC
Message-ID: <CAN0heSpUhzbTjceVhBxk_jjE=vOAVTzXGFQ=UL9Y+muJHe0S6w@mail.gmail.com>
In-Reply-To: <CALOYryEMB5HoCXbVKnc49KLkk2ySZjn4DG9RbJjQAvPn1H5K6Q@mail.gmail.com>

On Wed, 26 Sep 2018 at 11:00, Alexander Pyhalov <apyhalov@gmail.com> wrote:

> As for sign-off, do I understand correctly that you just want to know
> that I'm the original author of the code? Yes, it's so.

Right. Plus that you agree that the code (the commit) may be redistributed basically forever.

> I see this on OpenIndiana in
> https://github.com/OpenIndiana/oi-userland/pull/4456 , when running
> test suite.
> Not sure why it wasn't noticed earlier, as 'trash directory' is used in path.

My first theory was that my shell and that of other developers was "modern" or "clever" enough to realize that the space belongs to the filename, so it just takes everything to the end of line. Whereas your shell would be "dumber". I see now that you have a newer bash than I do... Maybe this cleverness can be configured (at compile-time?), or maybe something else is happening.

Show 6 quoted lines

> execve("/bin/bash", 0x007EA898, 0x007EA960)  argc = 5
> 2655:    argv: /bin/bash -c ./e\ space.sh "$@" ./e\ space.sh
> 2655:     /export/home/alp/srcs/oi-userland/components/developer/git/build/amd64/t/trash
> directory.t7005-editor/.git/COMMIT_EDITMSG
> 2655:   execve("./e space.sh", 0x005655C8, 0x00564008)  Err#8 ENOEXEC
> ./e space.sh: line 1: $1: ambiguous redirect

> Shell is bash, as you can see (GNU bash, version 4.4.23(1)-release
> (i386-pc-solaris2.11))

I came up with the following commit message. What do you think about it?

    t7005-editor: quote filename to fix whitespace-issue

    Commit 4362da078e (t7005-editor: get rid of the SPACES_IN_FILENAMES
    prereq, 2018-05-14) removed code for detecting whether spaces in
    filenames work. Since we rely on spaces throughout the test suite
    ("trash directory.t1234-foo"), testing whether we can use the filename
    "e space.sh" was redundant and unnecessary.

    In simplifying the code, though, the commit introduced a regression around
    how spaces are handled, not in the /name/ of the script, but /in/ the
    script itself. The editor-script created looks like this:

      echo space >$1

    We will try to execute something like

      echo space >/foo/t/trash directory.t7005-editor/.git/COMMIT_EDITMSG

    Most shells seem to be able to figure out that the filename doesn't end
    with "trash" but continues all the way to "COMMIT_EDITMSG", but at least
    one shell chokes on this.

    Make sure that the editor-script quotes "$1".

Martin