git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] help -a: handle aliases with long names gracefully

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 12, 2018, 09:43 UTC
Message-ID
<xmqqlg4vhygl.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<850cd5d15abe5b8a4356efe86ba81bc032278dce.1544540287.git.gitgitgadget@gmail.com>

"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 10 quoted lines
> From: Johannes Schindelin <johannes.schindelin@gmx.de>
>
> We take pains to determine the longest command beforehand, so that we
> can align the category column after printing the command names.
>
> However, then we re-use that value when printing the aliases. If any
> alias name is longer than the longest command name, we consequently try
> to add a negative number of spaces (but `mput_char()` does not expect
> any negative values and simply decrements until the value is 0, i.e.
> it tries to add close to 2**31 spaces).

Thanks. Let's take this and a few other topics that fix 2.20 brown paper bag breakages and prepare for 2.20.1 soonish.

Previous: Johannes Schindelin via GitGitGadget
Message 4 of 4 in “Fix git help -a with long alias names”
  1. 0/2 Fix git help -a with long alias namesJohannes Schindelin via GitGitGadget, Dec 11, 2018
  2. 1/2 help.h: fix coding styleJohannes Schindelin via GitGitGadget, Dec 11, 2018
  3. 2/2 help -a: handle aliases with long names gracefullyJohannes Schindelin via GitGitGadget, Dec 11, 2018
  4. Junio C HamanoDec 12, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.