git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/2] Fix git help -a with long alias names

From
Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>
Date
Dec 11, 2018, 14:58 UTC
Message-ID
<pull.97.git.gitgitgadget@gmail.com>

The code added in 26c7d0678324 (help -a: improve and make --verbose default, 2018-09-29) that intends to print out aliases in addition to commands failed to adjust for the length of the aliases. As a consequence, if there was any alias whose name is longer than 18 characters, git help -a tried to print an insanely large number of spaces, one at a time, causing what appeared to be a "hang".

Let's fix this, and while at it fix a style issue that I saw on the way as well.

Original report at https://github.com/git-for-windows/git/issues/1975
Johannes Schindelin (2):
  help.h: fix coding style
  help -a: handle aliases with long names gracefully
 help.c | 10 +++++++++-
 help.h |  2 +-
 2 files changed, 10 insertions(+), 2 deletions(-)
base-commit: 5d826e972970a784bd7a7bdf587512510097b8c7
Published-As: https://github.com/gitgitgadget/git/releases/tags/pr-97%2Fdscho%2Ffix-help-a-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-97/dscho/fix-help-a-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/97
-- 
gitgitgadget
Next: Johannes Schindelin via GitGitGadget
Message 1 of 4 in “Fix git help -a with long alias names”
  1. 0/2 Fix git help -a with long alias namesJohannes Schindelin via GitGitGadget, Dec 11, 2018
  2. 1/2 help.h: fix coding styleJohannes Schindelin via GitGitGadget, Dec 11, 2018
  3. 2/2 help -a: handle aliases with long names gracefullyJohannes Schindelin via GitGitGadget, Dec 11, 2018
  4. Junio C HamanoDec 12, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.