From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 12 Dec 2018 09:43:38 GMT
Subject: Re: [PATCH 2/2] help -a: handle aliases with long names gracefully
Message-ID: <xmqqlg4vhygl.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <850cd5d15abe5b8a4356efe86ba81bc032278dce.1544540287.git.gitgitgadget@gmail.com>

"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
writes:

> From: Johannes Schindelin <johannes.schindelin@gmx.de>
>
> We take pains to determine the longest command beforehand, so that we
> can align the category column after printing the command names.
>
> However, then we re-use that value when printing the aliases. If any
> alias name is longer than the longest command name, we consequently try
> to add a negative number of spaces (but `mput_char()` does not expect
> any negative values and simply decrements until the value is 0, i.e.
> it tries to add close to 2**31 spaces).

Thanks.  Let's take this and a few other topics that fix 2.20 brown
paper bag breakages and prepare for 2.20.1 soonish.