Re: [PATCH v2 1/6] midx: add MIDX_PROGRESS flag <snip>

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 28, 2019, 03:40 UTC
Message-ID: <xmqqlfu9krzv.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20190921121104.GA6787@szeder.dev>

SZEDER Gábor <szeder.dev@gmail.com> writes:

Show 12 quoted lines

> On Fri, Sep 20, 2019 at 09:53:48AM -0700, William Baker via GitGitGadget wrote:
>> diff --git a/midx.h b/midx.h
>> index f0ae656b5d..e6fa356b5c 100644
>> --- a/midx.h
>> +++ b/midx.h
>> @@ -37,6 +37,8 @@ struct multi_pack_index {
>>  	char object_dir[FLEX_ARRAY];
>>  };
>>  
>> +#define MIDX_PROGRESS     (1 << 0)
>
> Please consider using an enum.

If they are used by assiging one of their values, definitely a good idea to use an enum. Are debuggers clever enough that they can tell, when they see something like this:

	enum gress {
		PROGRESS = 1,
		REGRESS = 2,
	};

	void func(enum gress v);

...

        void caller(void)
	{
		func(PROGRESS | REGRESS);
		func(PROGRESS + REGRESS);
		func(PROGRESS * 3);
	}

how caller came about to give 3?