Re: [PATCH 0/1] sequencer: comment out the 'squash!' line

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 7, 2020, 16:15 UTC
Message-ID: <xmqqlfqj6y5n.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20200107013401.GI6570@camp.crustytoothpaste.net>

"brian m. carlson" <sandals@crustytoothpaste.net> writes:

> I can see the argument that this makes it a little harder for mechanical
> processing across versions, but I suspect most of that looks something
> like "sed -i -e '/^squash! /d' COMMIT_EDITMSG" and it probably won't be
> affected.

With the left-anchoring, the search pattern will no longer find that line if "squash!" is commented out, but people tend to be sloppy and do not anchor the pattern would not notice the difference. Perhaps the downside may not be too severe? I dunno.

> We do make occasional slightly incompatible changes across
> versions in order to improve user experience, and I think a lot of folks
> who use squash commits will find this a pleasant improvement.