Re: [PATCH 0/1] sequencer: comment out the 'squash!' line

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 6, 2020, 20:41 UTC
Message-ID: <xmqqimlo8ghi.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <CANoM8SV=pT3sFrfnEqWc2xBn_c2rES0qSMsdptF0DgcxgYL94w@mail.gmail.com>

Mike Rappazzo <rappazzo@gmail.com> writes:

> This change isn't removing the subject line from the commit message
> during the edit phase, it is only commenting it out.  With the subject being
> commented out, it can minimize the effort to edit during the squash.

Which means existing automation will be broken if they are not taught to be aware that these subject lines can now be commented out if their Git is recent enough, which does not sound like a good thing.

> Furthermore, it can help to eliminate accidental inclusion in the final
> message.  Ultimately, the accidental inclusion is my motivation for
> submitting this.

Yes, but that is why the concatenated messages are given to the editor to be "edited" by you, to be better than just a concatenation, right? When I deal with a "squash" (not "fixup"), the end result would have a log message for a single commit that describes the single thing it does, which would not resemble to the original of any of the squashed message---and removing extra title lines would be the smallest part of such an edit. So...