Re: [PATCH 0/1] sequencer: comment out the 'squash!' line

From: brian m. carlson <sandals@crustytoothpaste.net>
Date: Jan 8, 2020, 02:55 UTC
Message-ID: <20200108025509.GM6570@camp.crustytoothpaste.net>
In-Reply-To: <xmqqlfqj6y5n.fsf@gitster-ct.c.googlers.com>

On 2020-01-07 at 16:15:16, Junio C Hamano wrote:

Show 11 quoted lines

> "brian m. carlson" <sandals@crustytoothpaste.net> writes:
> 
> > I can see the argument that this makes it a little harder for mechanical
> > processing across versions, but I suspect most of that looks something
> > like "sed -i -e '/^squash! /d' COMMIT_EDITMSG" and it probably won't be
> > affected.
> 
> With the left-anchoring, the search pattern will no longer find that
> line if "squash!" is commented out, but people tend to be sloppy and
> do not anchor the pattern would not notice the difference.  Perhaps
> the downside may not be too severe?  I dunno.

Sorry, I was perhaps bad at explaining this. In my example, it would no longer remove that line, but the user wouldn't care, because it would be commented out and removed automatically. So while the code wouldn't work, what the user wanted would be done by Git automatically.

-- 
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204