Re: [PATCH v3 1/2] submodule--helper: use C99 named initializer
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 22, 2020, 20:13 UTC
- Message-ID
- <xmqqlfounzwy.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <20200221031027.204486-2-emilyshaffer@google.com>
Emily Shaffer <emilyshaffer@google.com> writes:
> Start using a named initializer list for SUBMODULE_UPDATE_CLONE_INIT, as
The feature has its own name. Instead of coming up with your own name for it, let's say "designated initializers".
Show 11 quoted lines
> -#define SUBMODULE_UPDATE_CLONE_INIT {0, MODULE_LIST_INIT, 0, \
> - SUBMODULE_UPDATE_STRATEGY_INIT, 0, 0, -1, STRING_LIST_INIT_DUP, 0, 0, \
> - NULL, NULL, NULL, \
> - NULL, 0, 0, 0, NULL, 0, 0, 1}
> +#define SUBMODULE_UPDATE_CLONE_INIT { \
> + .list = MODULE_LIST_INIT, \
> + .update = SUBMODULE_UPDATE_STRATEGY_INIT, \
> + .recommend_shallow = -1, \
> + .references = STRING_LIST_INIT_DUP, \
> + .max_jobs = 1 \
> +}This does make it read more easily. If you ended the last field with trailing comma, that would have been even better as a future proofing ;-)