Re: [PATCH v3 2/2] clone: pass --single-branch during --recurse-submodules
- From
Jeff King <peff@peff.net>
- Date
- Feb 21, 2020, 05:28 UTC
- Message-ID
- <20200221052818.GB1280313@coredump.intra.peff.net>
- In-Reply-To
- <20200221031027.204486-3-emilyshaffer@google.com>
On Thu, Feb 20, 2020 at 07:10:27PM -0800, Emily Shaffer wrote:
> Previously, performing "git clone --recurse-submodules --single-branch" > resulted in submodules cloning all branches even though the superproject > cloned only one branch. Pipe --single-branch through the submodule > helper framework to make it to 'clone' later on.
This looks good to me, with the exception of the open question I had earlier about testing the case where the needed commit isn't covered by the single branch.
-Peff