Re: [PATCH v4 8/8] clean/smudge: allow clean filters to process extremely large files

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 4, 2021, 17:26 UTC
Message-ID: <xmqqlf233k80.fsf@gitster.g>
In-Reply-To: <41fda423982d99847d3879f5ea1eb3570ae9eab6.1635867971.git.gitgitgadget@gmail.com>

"Matt Cooper via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 7 quoted lines

>  struct filter_params {
>  	const char *src;
> -	unsigned long size;
> +	size_t size;
>  	int fd;
>  	const char *cmd;
>  	const char *path;

OK, this member is used in only two places in the file. One is used as a parameter to write_in_full() that is prepared to take size_t. The other is to assign to this member from a size_t parameter the apply_single_file_filter() function got from the caller, and the callchain leading down to the function are size_t aware.

So, this may only make "a small dent" as described in the proposed log message, but it does move it in the right direction.

Thanks.