Re: [PATCH 1/3] test-lib: add prerequisite for 64-bit platforms

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Oct 28, 2021, 21:45 UTC
Message-ID: <nycvar.QRO.7.76.6.2110282344330.56@tvgsbejvaqbjf.bet>
In-Reply-To: <20211028205649.84036-2-carenas@gmail.com>

Hi Carlo,

On Thu, 28 Oct 2021, Carlo Marcelo Arenas Belón wrote:

> Allow tests that assume a 64-bit size_t to be skipped in 32-bit platforms
> and regardless of the size of long.

Makes sense, but...

Show 15 quoted lines

>
> Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>
> ---
>  t/test-lib.sh | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/t/test-lib.sh b/t/test-lib.sh
> index fc1e521519..5fa7fb5719 100644
> --- a/t/test-lib.sh
> +++ b/t/test-lib.sh
> @@ -1687,6 +1687,10 @@ build_option () {
>  	sed -ne "s/^$1: //p"
>  }
>
> +test_lazy_prereq IS_64BIT '

This should be `SIZE_T_IS_64BIT`.

> +	test 8 -eq "$(build_option sizeof-size_t)"

Since this is clearly copied from `LONG_IS_64BIT`, why the change from `-le` to `-eq`? It is at least inconsistent to use anything different here.

Ciao, Dscho

Show 10 quoted lines

> +'
> +
>  test_lazy_prereq LONG_IS_64BIT '
>  	test 8 -le "$(build_option sizeof-long)"
>  '
> --
> 2.33.0.1155.gbdb71ac078
>
>
>