Re: ab/remove--super-prefix & ab/submodule-no-abspath

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 23, 2022, 02:19 UTC
Message-ID: <xmqqleo2o1k3.fsf@gitster.g>
In-Reply-To: <221123.86edtua8i6.gmgdl@evledraar.gmail.com>

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

Show 12 quoted lines

>> * ab/submodule-no-abspath (2022-11-09) 1 commit
>>   (merged to 'next' on 2022-11-18 at 34d0accc7b)
>>  + submodule--helper absorbgitdirs: no abspaths in "Migrating git..."
>>  (this branch is used by ab/remove--super-prefix.)
>>
>>  Remove an absolute path in the "Migrating git directory" message.
>>
>>  Will merge to 'master'.
>>  source: <patch-1.1-34b54fdd9bb-20221109T020347Z-avarab@gmail.com>
>
> Glen pointed out an issue in ab/submodule-no-abspath which I just
> submitted a fix-on-top for in [1].

I'll queue that and keep the result in 'next' in the meantime, but given that this seems to induce additional conflicts and who knows what else is broken in it, I am not sure if it is a good use of our time to even worry about "fixing" it. What upside does it have with the patch, other than the "Migrating git" message, which does not even look like an improvement, at least to me?

> There will be a merge conflict with ab/remove--super-prefix, but one
> which I tried to make easy to resolve when crafting [1]. The resolution
> is:

... not something we would want to even worry about during -rc period.

Thanks.