git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: gc/resolve-alternate-symlinks (Re: What's cooking in git.git (Nov 2022, #05; Tue, 22))

From
Jeff King <peff@peff.net>
Date
Nov 22, 2022, 19:53 UTC
Message-ID
<Y30o0aHIEYRVw/pA@coredump.intra.peff.net>
In-Reply-To
<kl6lk03merud.fsf@chooglen-macbookpro.roam.corp.google.com>
On Tue, Nov 22, 2022 at 11:01:30AM -0800, Glen Choo wrote:
Show 20 quoted lines
> Junio C Hamano <gitster@pobox.com> writes:
> 
> > * gc/resolve-alternate-symlinks (2022-11-22) 1 commit
> >  - object-file: use real paths when adding alternates
> >
> >  Resolve symbolic links when processing the locations of alternate
> >  object stores, since failing to do so can lead to confusing and buggy
> >  behavior.
> >
> >  Will merge to 'next'.
> >  source: <pull.1382.v2.git.git.1669074557348.gitgitgadget@gmail.com>
> 
> I plan to do another reroll based off Ævar's feedback (thanks!), let's
> hold off on merging until then?
> 
> Separately, I'd also prefer to hear from Peff regarding my reading of
> 37a95862c6 (alternates: re-allow relative paths from environment,
> 2016-11-07) and whether we want to continue 'supporting' broken paths in
> the environment. I doubt it, but since he initially suggested it in his
> fixup patch [1], his opinon would be reassuring :)

I just left a review there. I agree with your approach, but I think there are a few small bits that will require a re-roll.

-Peff
Previous: Glen ChooNext: Ævar Arnfjörð Bjarmason
Message 3 of 6 in “What's cooking in git.git (Nov 2022, #05; Tue, 22)”
  1. Junio C HamanoNov 22, 2022
  2. gc/resolve-alternate-symlinks (Re: What's cooking in git.git (Nov 2022, #05; Tue, 22))Glen Choo, Nov 22, 2022
  3. Jeff KingNov 22, 2022
  4. ab/remove--super-prefix & ab/submodule-no-abspath (was: What's cooking in git.git (Nov 2022, #05; Tue, 22))Ævar Arnfjörð Bjarmason, Nov 22, 2022
  5. Junio C HamanoNov 23, 2022
  6. Taylor BlauNov 22, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.