gc/resolve-alternate-symlinks (Re: What's cooking in git.git (Nov 2022, #05; Tue, 22))

From: Glen Choo <chooglen@google.com>
Date: Nov 22, 2022, 19:01 UTC
Message-ID: <kl6lk03merud.fsf@chooglen-macbookpro.roam.corp.google.com>
In-Reply-To: <xmqqfseargo4.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

Show 9 quoted lines

> * gc/resolve-alternate-symlinks (2022-11-22) 1 commit
>  - object-file: use real paths when adding alternates
>
>  Resolve symbolic links when processing the locations of alternate
>  object stores, since failing to do so can lead to confusing and buggy
>  behavior.
>
>  Will merge to 'next'.
>  source: <pull.1382.v2.git.git.1669074557348.gitgitgadget@gmail.com>

I plan to do another reroll based off Ævar's feedback (thanks!), let's hold off on merging until then?

Separately, I'd also prefer to hear from Peff regarding my reading of 37a95862c6 (alternates: re-allow relative paths from environment, 2016-11-07) and whether we want to continue 'supporting' broken paths in the environment. I doubt it, but since he initially suggested it in his fixup patch [1], his opinon would be reassuring :)

[1] https://lore.kernel.org/git/Y3aBzbzub7flQyca@coredump.intra.peff.net/