Re: [PATCH v2 10/10] repository.h: drop unused `gc_cruft_packs`

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 19, 2023, 22:19 UTC
Message-ID: <xmqqlein7bwt.fsf@gitster.g>
In-Reply-To: <c67ee7c2ff9456eda1c5468cf68ddb1b83d37c85.1681850424.git.me@ttaylorr.com>

Taylor Blau <me@ttaylorr.com> writes:

Show 9 quoted lines

> As of the previous commit, all callers that need to read the value of
> `gc.cruftPacks` do so outside without using the `repo_settings` struct,
> making its `gc_cruft_packs` unused. Drop it accordingly.
>
> Signed-off-by: Taylor Blau <me@ttaylorr.com>
> ---
>  repo-settings.c | 4 +---
>  repository.h    | 1 -
>  2 files changed, 1 insertion(+), 4 deletions(-)

This is in line with the current design of repo-settings, and it is a total tangent to this topic, but in retrospect, if we structured how "what's experimental" is determined in a more distributed way, we didn't have to have this patch. That is, instead of saying "ok we are in a repository with experimental setting turned on, and the set of features to be enabled are centrally described in this settings structure", each opt-in features (like the code that reads "gc.cruftPacks" by calling git_config_get_bool() to override its default value) can select their default/fallback values by seeing if the experimental bit is set.

In any case, this patch looks good and we have one fewer such centrally managed bit.