From: Junio C Hamano Date: Wed, 19 Apr 2023 22:19:30 GMT Subject: Re: [PATCH v2 10/10] repository.h: drop unused `gc_cruft_packs` Message-ID: In-Reply-To: Taylor Blau writes: > As of the previous commit, all callers that need to read the value of > `gc.cruftPacks` do so outside without using the `repo_settings` struct, > making its `gc_cruft_packs` unused. Drop it accordingly. > > Signed-off-by: Taylor Blau > --- > repo-settings.c | 4 +--- > repository.h | 1 - > 2 files changed, 1 insertion(+), 4 deletions(-) This is in line with the current design of repo-settings, and it is a total tangent to this topic, but in retrospect, if we structured how "what's experimental" is determined in a more distributed way, we didn't have to have this patch. That is, instead of saying "ok we are in a repository with experimental setting turned on, and the set of features to be enabled are centrally described in this settings structure", each opt-in features (like the code that reads "gc.cruftPacks" by calling git_config_get_bool() to override its default value) can select their default/fallback values by seeing if the experimental bit is set. In any case, this patch looks good and we have one fewer such centrally managed bit.