Re: [PATCH 00/10] gc: enable cruft packs by default

From: Jeff King <peff@peff.net>
Date: Apr 18, 2023, 11:04 UTC
Message-ID: <20230418110424.GD516715@coredump.intra.peff.net>
In-Reply-To: <cover.1681764848.git.me@ttaylorr.com>

On Mon, Apr 17, 2023 at 04:54:11PM -0400, Taylor Blau wrote:

Show 10 quoted lines

> The series is structured as follows:
> 
>   - The first two patches are cleanup.
>   - The third patches fixes an oversight where the code for `git gc`'s
>     `--keep-largest-pack` option would incorrectly consider cruft packs.
>   - The next five patches are test preparation.
>   - Then the substantive patch, to actually graduate `gc.cruftPacks` and
>     enable it by default.
>   - The final patch is some cleanup that can only take place towards the
>     end of the series.

Thanks, this was a pleasant read. Besides Junio's small fixup in the docs, everything I pointed out was minor enough that it wouldn't be a big deal to go in as-is.

> Cruft packs have been a success for us at GitHub, and I am really
> excited to get it in the hands of more users by default.

Me too. :)

-Peff