Re: [BUG] Git 2.41.0-rc0 - Compile Error ALLOC_GROW

From: Junio C Hamano <gitster@pobox.com>
Date: May 16, 2023, 17:19 UTC
Message-ID: <xmqqlehourbf.fsf@gitster.g>
In-Reply-To: <ZGO4LesPe4A2ftdm@nand.local>

Taylor Blau <me@ttaylorr.com> writes:

Ah, alloc.h was introduced and everybody who took ALLOC_GROW() from git-compat-util.h (or was it cache.h?) now includes it, but apparently Elijah forgot run-command.c and nobody caught this.

I wonder if there are other leftover ones that we haven't caught?

    $ git grep -l '[^_]ALLOC_GROW(' \*.c | sort >/var/tmp/1
    $ git grep -l 'alloc\.h' \*.c | sort >/var/tmp/2
    $ comm -23 /var/tmp/[12]
    compat/simple-ipc/ipc-unix-socket.c
    run-command.c

But the former one is only in a comment, so it probably is OK.