git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] run-command.c: need alloc.h for our own at-exit handler emulation

From
Taylor Blau <me@ttaylorr.com>
Date
May 16, 2023, 18:01 UTC
Message-ID
<ZGPE9ozRChUJ3NGV@nand.local>
In-Reply-To
<ZGPEHu2pCYfdNI0h@nand.local>
On Tue, May 16, 2023 at 01:57:50PM -0400, Taylor Blau wrote:
Show 10 quoted lines
> On Tue, May 16, 2023 at 10:24:24AM -0700, Junio C Hamano wrote:
> > Recent header file shuffling missed this old user of ALLOC_GROW()
> > that was inside "#ifdef NO_PTHREADS' section and forgot to include
> > the new file, alloc.h, that defines the macro.
>
> Heh. I wrote an identical patch before lunch (which I just came back
> from). Feel free to queue either, I honestly do not care which as long
> as the bug is fixed :-).
>
>   https://lore.kernel.org/git/db403de74da839084165f11dab05d71484457c6f.1684259780.git.me@ttaylorr.com/

OK, having now read both completely, I would say I have a vague preference for my version since it keeps the include at the top and unconditional, and has slightly more information in the patch message.

But I do not prefer it so much over yours that I would be sad if you had already queued yours and didn't want to bother shuffling it around.

Thanks, Taylor

Previous: Taylor BlauNext: Junio C Hamano
Message 7 of 15 in “[BUG] Git 2.41.0-rc0 - Compile Error ALLOC_GROW”
  1. rsbecker@nexbridge.comMay 16, 2023
  2. Taylor BlauMay 16, 2023
  3. Junio C HamanoMay 16, 2023
  4. run-command.c: need alloc.h for our own at-exit handler emulationJunio C Hamano, May 16, 2023
  5. rsbecker@nexbridge.comMay 16, 2023
  6. Taylor BlauMay 16, 2023
  7. Taylor BlauMay 16, 2023
  8. Junio C HamanoMay 16, 2023
  9. Taylor BlauMay 16, 2023
  10. Junio C HamanoMay 16, 2023
  11. run-command.c: fix missing include under `NO_PTHREADS`Taylor Blau, May 16, 2023
  12. Junio C HamanoMay 16, 2023
  13. rsbecker@nexbridge.comMay 16, 2023
  14. Taylor BlauMay 16, 2023
  15. Elijah NewrenMay 18, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.