Re: [PATCH] send-email: add --compose-cover option

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 12, 2023, 20:31 UTC
Message-ID: <xmqqlec7mvl1.fsf@gitster.g>
In-Reply-To: <277a80c5-40c9-4f1e-a68f-96673380012b@app.fastmail.com>

"Kristoffer Haugsbakk" <code@khaugsbakk.name> writes:

Show 6 quoted lines

> 2. This would be really useful in `format-patch`. One could write the
>    cover letter immediately instead of either (1) editing the generated
>    one (placeholders) or (2) providing a file.
>    - Personally I don't use `send-email` immediately—I use `format-patch`
>      to generate everything so that I can review it before any
>      sending. But there are many different workflows.

Hmph, I am not sure why a format-patch user would bother with the "--compose-cover" option for the cover letter, to be honest. I am a format-patch user and never drive it from send-email, just like the workflow you use, and the norm to me is to review everything, not just the cover letter but also the patches, in my editor session. You apparently do not need "--edit-patches" option to review and adjust as needed before sending, even though that is what you do already. Why do you need a "--compose-cover" option?