Re: [PATCH] send-email: add --compose-cover option

From: Kristoffer Haugsbakk <code@khaugsbakk.name>
Date: Oct 12, 2023, 20:48 UTC
Message-ID: <789b885d-19e6-49f9-a1b4-230a9bfa4d75@app.fastmail.com>
In-Reply-To: <xmqqlec7mvl1.fsf@gitster.g>

On Thu, Oct 12, 2023, at 22:31, Junio C Hamano wrote:

Show 8 quoted lines

> Hmph, I am not sure why a format-patch user would bother with the
> "--compose-cover" option for the cover letter, to be honest.  I am a
> format-patch user and never drive it from send-email, just like the
> workflow you use, and the norm to me is to review everything, not
> just the cover letter but also the patches, in my editor session.
> You apparently do not need "--edit-patches" option to review and
> adjust as needed before sending, even though that is what you do
> already.  Why do you need a "--compose-cover" option?

The thought was to get an interactive editor session for the subject and the message and let `format-patch` fill in the range-diff etc., but on second thought I have to do so many edits (fix mistakes and use the cover letter in later versions) that an interactive session would probably not be useful for me, after all. If so I would probably need to use some tool that makes cover-letter a first-class entity that you can edit multiple times similar to a commit message, like `git-series` (I'm guessing that's how it works?).

The upcoming `--description-file`[1] is probably what I'm gonna end up using.

[1] https://lore.kernel.org/git/20230821170720.577820-1-oswald.buddenhagen@gmx.de/

-- 
Kristoffer Haugsbakk