Re: [PATCH] send-email: add --compose-cover option

From: Kristoffer Haugsbakk <code@khaugsbakk.name>
Date: Oct 12, 2023, 20:03 UTC
Message-ID: <277a80c5-40c9-4f1e-a68f-96673380012b@app.fastmail.com>
In-Reply-To: <20231012112743.2756259-1-ben.dooks@codethink.co.uk>

Hi Ben

On Thu, Oct 12, 2023, at 13:27, Ben Dooks wrote:

> Adding an option to automatically compose a cover letter would be
> helpful to put the whole process of sending an series with a cover
> into one command.

I didn't manage to apply the patch so I haven't tried it out. Some questions:

1. There is already `--compose` which is clearly different. What's the
   difference between a cover letter an an introduction? That's a more
   immediate question now with two similar-looking options.
2. This would be really useful in `format-patch`. One could write the
   cover letter immediately instead of either (1) editing the generated
   one (placeholders) or (2) providing a file.
   - Personally I don't use `send-email` immediately—I use `format-patch`
     to generate everything so that I can review it before any
     sending. But there are many different workflows.
3. Does this editor only deal with the subject and the message part before
   the diffstat and all the auto-generated stuff? And then it applies it
   after the user closes the editor (to make the complete cover letter)?

-- 
Kristoffer Haugsbakk