Re: [PATCH/RFC] sparse-checkout: take care of "--end-of-options" in set/add

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 21, 2023, 22:04 UTC
Message-ID: <xmqqle9njjp3.fsf@gitster.g>
In-Reply-To: <20231221214550.GD1446091@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 10 quoted lines

> Right, that is the "gotcha" I mentioned in my other email. Though that
> is the way it has behaved historically, my argument is that users are
> unreasonable to expect it to work:
>
>   1. It is not consistent with the rest of Git commands.
>
>   2. It is inconsistent with respect to existing options (and is an
>      accident waiting to happen when new options are added).
>
> So I'd consider it a bug-fix.

So the counter-proposal here is just to drop KEEP_UNKNOWN_OPT and deliberately break them^W^W^Wrealign their expectations?

I do not have much stake in sparse-checkout, so I am fine with that direction. But I suspect other folks on the list would have users of their own who would rather loudly complain to them if we broke them ;-)

I'll see how bad the fallout would be if we go that route, using the test modification I made for the previous rounds as yardsticks.

Thanks.