Re: [PATCH/RFC] sparse-checkout: take care of "--end-of-options" in set/add

From: Jeff King <peff@peff.net>
Date: Dec 21, 2023, 08:40 UTC
Message-ID: <20231221084011.GB545870@coredump.intra.peff.net>
In-Reply-To: <xmqqplz0p90k.fsf@gitster.g>

On Wed, Dec 20, 2023 at 06:46:51PM -0800, Junio C Hamano wrote:

Show 8 quoted lines

> Josh Steadmon <steadmon@google.com> writes:
> 
> > I can confirm that this fixes an issue noticed by sparse-checkout users
> > at $DAYJOB. Looks good to me. Thanks!
> 
> Heh, there is another one that is not converted in the same file for
> "check-rules" subcommand, so the posted patch is way incomplete, I
> think.

Yeah. I think it is in the same boat as the other two, in that I believe that the KEEP_UNKNOWN_OPT flag is counter-productive and should just be dropped.

-Peff