Re: [RFC/PATCH] archive: "--list" does not take further options

From: Jeff King <peff@peff.net>
Date: Dec 21, 2023, 21:35 UTC
Message-ID: <20231221213543.GC1446091@coredump.intra.peff.net>
In-Reply-To: <xmqqmsu3mnix.fsf@gitster.g>

On Thu, Dec 21, 2023 at 10:13:58AM -0800, Junio C Hamano wrote:

Show 5 quoted lines

> Thanks, both.  Just to tie the loose end, let me queue this and
> merge it to 'next'.
> 
> ----- >8 --------- >8 --------- >8 -----
> Subject: [PATCH] archive: "--list" does not take further options

This looks fine to me. It does mean that this sequence of commands no longer works:

  [let's try to make a "foo" archive]
  $ git archive --format=foo HEAD
  fatal: Unknown archive format 'foo'

  [oops, that didn't work. What formats are supported?]
  $ !! --list
  git archive --format=foo HEAD --list
  tar
  tgz
  tar.gz
  zip

I think that's OK in practice. The increased error checking is worth it (and matches many other commands, which tend to warn about confusing extra bits).

-Peff