Re: [PATCH 2/7] t0410: enable tests with extensions with non-default repo format
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 14, 2024, 22:57 UTC
- Message-ID
- <xmqqle7mu00c.fsf@gitster.g>
- In-Reply-To
- <feef6a3e6cd0d9096816d0a8a5789837fb784517.1707463221.git.ps@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
Show 9 quoted lines
> In t0410 we have two tests which exercise how partial clones behave in > the context of a repository with extensions. These tests are marked to > require a default repository using SHA1 and the "files" backend because > we explicitly set the repository format version to 0. > > Changing the repository format version to 0 is not needed though. The > "noop" extension is ignored as expected regardless of what the version > is set to, same as the "nonsense" extension leads to failure regardless > of the version.
Isn't the reason why 11664196 kept the forcing of the format version because it wanted to see noop ignored and nonsense failed even if the format version is 0 to ensure the regression it fixed will stay fixed? IOW, we force version 0 not because we do not want to test with anything but SHA1 and REFFILES; we pretty much assume that with the default version, noop and nonsense will be handled sensibly, and we want to make sure they will be with version 0 as well.
And once we force to version 0, we have trouble running with anything other than SHA1 and REFFILES, hence these prerequisites.
So, I dunno.
Show 40 quoted lines
> > Stop setting the version so that these tests can execute with SHA256 and > "reftable" repositories. > > Signed-off-by: Patrick Steinhardt <ps@pks.im> > --- > t/t0410-partial-clone.sh | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/t/t0410-partial-clone.sh b/t/t0410-partial-clone.sh > index 6b6424b3df..d913f3c453 100755 > --- a/t/t0410-partial-clone.sh > +++ b/t/t0410-partial-clone.sh > @@ -49,24 +49,22 @@ test_expect_success 'convert shallow clone to partial clone' ' > test_cmp_config -C client 1 core.repositoryformatversion > ' > > -test_expect_success SHA1,REFFILES 'convert to partial clone with noop extension' ' > +test_expect_success 'convert to partial clone with noop extension' ' > rm -fr server client && > test_create_repo server && > test_commit -C server my_commit 1 && > test_commit -C server my_commit2 1 && > git clone --depth=1 "file://$(pwd)/server" client && > - test_cmp_config -C client 0 core.repositoryformatversion && > git -C client config extensions.noop true && > git -C client fetch --unshallow --filter="blob:none" > ' > > -test_expect_success SHA1,REFFILES 'converting to partial clone fails with unrecognized extension' ' > +test_expect_success 'converting to partial clone fails with unrecognized extension' ' > rm -fr server client && > test_create_repo server && > test_commit -C server my_commit 1 && > test_commit -C server my_commit2 1 && > git clone --depth=1 "file://$(pwd)/server" client && > - test_cmp_config -C client 0 core.repositoryformatversion && > git -C client config extensions.nonsense true && > test_must_fail git -C client fetch --unshallow --filter="blob:none" > '