git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 5/7] t1405: remove unneeded cleanup step

From
Patrick Steinhardt <ps@pks.im>
Date
Feb 9, 2024, 07:23 UTC
Message-ID
<25cf00c36f715edc6b4e86001a36a093f4c4b2e0.1707463221.git.ps@pks.im>
In-Reply-To
<cover.1707463221.git.ps@pks.im>

In 5e00514745 (t1405: explictly delete reflogs for reftable, 2022-01-31) we have added a test that explicitly deletes the reflog when not using the "files" backend. This was required because back then, the "reftable" backend didn't yet delete reflogs when deleting their corresponding branches, and thus subsequent tests would fail because some unexpected reflogs still exist.

The "reftable" backend was eventually changed though so that it behaves the same as the "files" backend and deletes reflogs when deleting refs. This was done to make the "reftable" backend behave like the "files" backend as closely as possible so that it can act as a drop-in replacement.

The cleanup-style test is thus not required anymore. Remove it.
Signed-off-by: Patrick Steinhardt <ps@pks.im>
---
 t/t1405-main-ref-store.sh | 6 ------
 1 file changed, 6 deletions(-)
diff --git a/t/t1405-main-ref-store.sh b/t/t1405-main-ref-store.sh
index 976bd71efb..1183232a72 100755
--- a/t/t1405-main-ref-store.sh
+++ b/t/t1405-main-ref-store.sh
@@ -33,12 +33,6 @@ test_expect_success 'delete_refs(FOO, refs/tags/new-tag)' '
 	test_must_fail git rev-parse refs/tags/new-tag --
 '
 
-# In reftable, we keep the reflogs around for deleted refs.
-test_expect_success !REFFILES 'delete-reflog(FOO, refs/tags/new-tag)' '
-	$RUN delete-reflog FOO &&
-	$RUN delete-reflog refs/tags/new-tag
-'
-
 test_expect_success 'rename_refs(main, new-main)' '
 	git rev-parse main >expected &&
 	$RUN rename-ref refs/heads/main refs/heads/new-main &&
-- 
2.43.GIT
Previous: Junio C HamanoNext: Junio C Hamano
Message 12 of 28 in “t: drop more REFFILES prereqs”
  1. 0/7 t: drop more REFFILES prereqsPatrick Steinhardt, Feb 9, 2024
  2. 1/7 t: move tests exercising the "files" backendPatrick Steinhardt, Feb 9, 2024
  3. Junio C HamanoFeb 14, 2024
  4. 2/7 t0410: enable tests with extensions with non-default repo formatPatrick Steinhardt, Feb 9, 2024
  5. Junio C HamanoFeb 14, 2024
  6. Patrick SteinhardtFeb 15, 2024
  7. Junio C HamanoFeb 15, 2024
  8. 3/7 t1400: exercise reflog with gaps with reftable backendPatrick Steinhardt, Feb 9, 2024
  9. Junio C HamanoFeb 14, 2024
  10. 4/7 t1404: make D/F conflict tests compatible with reftable backendPatrick Steinhardt, Feb 9, 2024
  11. Junio C HamanoFeb 14, 2024
  12. 5/7 t1405: remove unneeded cleanup stepPatrick Steinhardt, Feb 9, 2024
  13. Junio C HamanoFeb 14, 2024
  14. Patrick SteinhardtFeb 15, 2024
  15. 6/7 t2011: exercise D/F conflicts with HEAD with the reftable backendPatrick Steinhardt, Feb 9, 2024
  16. 7/7 t7003: ensure filter-branch prunes reflogs with the reftable backendPatrick Steinhardt, Feb 9, 2024
  17. Karthik NayakFeb 11, 2024
  18. Junio C HamanoFeb 14, 2024
  19. Patrick SteinhardtFeb 15, 2024
  20. 0/7 t: drop more REFFILES prereqsPatrick Steinhardt, Feb 15, 2024
  21. 1/7 t: move tests exercising the "files" backendPatrick Steinhardt, Feb 15, 2024
  22. 2/7 t0410: convert tests to use DEFAULT_REPO_FORMAT prereqPatrick Steinhardt, Feb 15, 2024
  23. Junio C HamanoFeb 15, 2024
  24. 3/7 t1400: exercise reflog with gaps with reftable backendPatrick Steinhardt, Feb 15, 2024
  25. 4/7 t1404: make D/F conflict tests compatible with reftable backendPatrick Steinhardt, Feb 15, 2024
  26. 5/7 t1405: remove unneeded cleanup stepPatrick Steinhardt, Feb 15, 2024
  27. 6/7 t2011: exercise D/F conflicts with HEAD with the reftable backendPatrick Steinhardt, Feb 15, 2024
  28. 7/7 t7003: ensure filter-branch prunes reflogs with the reftable backendPatrick Steinhardt, Feb 15, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.