Re: [PATCH v2 2/7] t0410: convert tests to use DEFAULT_REPO_FORMAT prereq

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 15, 2024, 18:19 UTC
Message-ID: <xmqq34ttsi8i.fsf@gitster.g>
In-Reply-To: <2dd87f3126cedd39cb5b113053c90ee35ae0e5ff.1707985173.git.ps@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

> We have recently introduced a new DEFAULT_REPO_FORMAT prerequisite.
> Despite capturing the intent more directly, it also has the added
> benefit that it can easily be extended in the future in case we add new
> repository extensions. Adapt the tests to use it.

That is a good explanation. Instead of lifting the prerequisite and forcing version 0 altogether, we can move by one step (I am puzzled by "despite" though).

As I said in a separate message, as long as we make sure somebody will test with version 0, we do not mind if other people test with higher versions, so in that sense, the patch in v1 may be closer to what we want to have in the longer term (but we need to figure out how we "make sure somebody will test with version 0" first).

Thanks, will queue.

Show 14 quoted lines

> -test_expect_success SHA1,REFFILES 'convert to partial clone with noop extension' '
> +test_expect_success DEFAULT_REPO_FORMAT 'convert to partial clone with noop extension' '
>  	rm -fr server client &&
>  	test_create_repo server &&
>  	test_commit -C server my_commit 1 &&
> @@ -60,7 +60,7 @@ test_expect_success SHA1,REFFILES 'convert to partial clone with noop extension'
>  	git -C client fetch --unshallow --filter="blob:none"
>  '
>  
> -test_expect_success SHA1,REFFILES 'converting to partial clone fails with unrecognized extension' '
> +test_expect_success DEFAULT_REPO_FORMAT 'converting to partial clone fails with unrecognized extension' '
>  	rm -fr server client &&
>  	test_create_repo server &&
>  	test_commit -C server my_commit 1 &&